Title

Message call with hardcoded gas amount

Relationships

Description

The transfer() and send() functions forward a fixed amount of 2300 gas. Historically, it has often been recommended to use these functions for value transfers to guard against reentrancy attacks. However, the gas cost of EVM instructions may change significantly during hard forks which may break already deployed contract systems that make fixed assumptions about gas costs. For example. EIP 1884 broke several existing smart contracts due to a cost increase of the SLOAD instruction.

Remediation

Avoid the use of transfer() and send() and do not otherwise specify a fixed amount of gas when performing calls. Use .call.value(...)("") instead. Use the checks-effects-interactions pattern and/or reentrancy locks to prevent reentrancy attacks.

References

Contract Samples

hardcoded_gas_limits.sol

/*
 * @author: Bernhard Mueller (ConsenSys / MythX)
 */

pragma solidity 0.6.4;

interface ICallable {
    function callMe() external;
}

contract HardcodedNotGood {

    address payable _callable = 0xaAaAaAaaAaAaAaaAaAAAAAAAAaaaAaAaAaaAaaAa;
    ICallable callable = ICallable(_callable);

    constructor() public payable {
    }

    function doTransfer(uint256 amount) public {
        _callable.transfer(amount);
    }

    function doSend(uint256 amount) public {
        _callable.send(amount);
    }

     function callLowLevel() public {
         _callable.call.value(0).gas(10000)("");
     }

     function callWithArgs() public {
         callable.callMe{gas: 10000}();
     }
}

hardcoded_gas_limits.yaml

description: Hardcoded gas limit
issues:
- id: SWC-134
  count: 4
  locations:
  - bytecode_offsets: {}
    line_numbers:
      hardcoded_gas_limits.sol: [20]
  - bytecode_offsets: {}
    line_numbers:
      hardcoded_gas_limits.sol: [24]
  - bytecode_offsets: {}
    line_numbers:
      hardcoded_gas_limits.sol: [28]
  - bytecode_offsets: {}
    line_numbers:
      hardcoded_gas_limits.sol: [32]